AOSSIE-Org / Resonate

Clubhouse, but Open Source. A social voice platform.
GNU General Public License v3.0
171 stars 123 forks source link

Fix bottom overflowed error on login screen, Fix the Splash radius of buttons on profile page and minor changes #266

Closed bhawesh2002 closed 3 months ago

bhawesh2002 commented 4 months ago

Description

Major fixes:

  1. Fix Splash radius of buttons on profile page
  2. Fix the RenderFlex overflowed error of discussion tile
  3. Fix bottom overflowed error on login screen

Minor Changes

  1. Remove unused imports from the code files inside lib dir to improve performance
  2. Rename identifiers according to lowerCamelCase naming convenction
  3. Add const modifier wherever possible to improve performance
  4. Use debugPrint instead of print
  5. Remove unnessary string interpolations

Fixes

Major:

  1. The splash radius of buttons on the profile page exceeds the border #284
  2. Bug:- Bottom overflowed error on login screen #287

Minor:

  1. Remove unused import #248
  2. use lowerCamelCase identifier names #267
  3. Clearing up Unused Imports & Improving Performance #158

Type of change

Major

  1. Make use of Material widget to wrap InkWell and specify border radius to avoid the overflow of splash when button is tapped. Before: Screenshot_1709188487 After: Screenshot_1709190839

  2. Change the layout of login screen widgets to account for a more responsive design. Before Screenshot_20240301-102153 After: Screenshot_20240301-112133

Minor

  1. Remove unused imports to keep the code clean and improve performance
  2. Rename identifiers as specified in non_constant_identifier_names
  3. Add const modifers to improve performance which notifies dart that the widgets with const modifiers are compile-time constants.
  4. Use debugPrint instead of print as specified in avoid print calls in production code.
  5. Remove unnessary string interpolations as specified in unnecessary_string_interpolations

How Has This Been Tested?

Tested manually on android emulator(API 31 and API 34) and Moto g40 fusion. No errors were encountered after the changes were made.

Checklist:

Maintainer Checklist

bhawesh2002 commented 4 months ago

I have removed unused imports and made some refactoring changes to the code files.

bhawesh2002 commented 4 months ago

I have renamed identifiers according to lowerCamelCase naming convenction

bhawesh2002 commented 4 months ago

I have added const modifier wherever possible to improve performance as specified in prefer_const_constructors

bhawesh2002 commented 4 months ago

Have you tested the whole app after these changes ?

Yes. I did test the changes on API 34 emulator and physical device running API 32 as well and everything worked fine. NOTE: I tested the changes about a week ago. I am unable to launch application becaues of the _TypeError (Null check operator used on a null value) exception. This exception is being throwned when launching the app. The same issue is being faced by others as well. Check Issue: #288

bhawesh2002 commented 4 months ago

Update: After following this and testing the app on API 34,33 and 32 the app works perfectly fine and the changes do not cause any new issues.

bhawesh2002 commented 4 months ago

@chandansgowda Update: I made the changes to UiSizes refering to #291 and tested the app. The app is working fine and throws no errors.