Closed bhawesh2002 closed 3 months ago
I have removed unused imports and made some refactoring changes to the code files.
I have renamed identifiers according to lowerCamelCase naming convenction
I have added const modifier wherever possible to improve performance as specified in prefer_const_constructors
Have you tested the whole app after these changes ?
Yes. I did test the changes on API 34 emulator and physical device running API 32 as well and everything worked fine.
NOTE: I tested the changes about a week ago. I am unable to launch application becaues of the
_TypeError (Null check operator used on a null value)
exception.
This exception is being throwned when launching the app. The same issue is being faced by others as well.
Check Issue: #288
Update: After following this and testing the app on API 34,33 and 32 the app works perfectly fine and the changes do not cause any new issues.
@chandansgowda Update: I made the changes to UiSizes refering to #291 and tested the app. The app is working fine and throws no errors.
Description
Major fixes:
Minor Changes
Fixes
Major:
Minor:
Type of change
Major
Make use of Material widget to wrap InkWell and specify border radius to avoid the overflow of splash when button is tapped. Before:
After:
![Screenshot_1709190839](https://github.com/AOSSIE-Org/Resonate/assets/55053472/e49fadfe-748d-4421-9a6f-9a3be2a4836c)
Change the layout of login screen widgets to account for a more responsive design. Before
After:
![Screenshot_20240301-112133](https://github.com/AOSSIE-Org/Resonate/assets/55053472/16172be9-d480-4497-adc4-22dcd8365295)
Minor
How Has This Been Tested?
Tested manually on android emulator(API 31 and API 34) and Moto g40 fusion. No errors were encountered after the changes were made.
Checklist:
Maintainer Checklist