Aarush-Acharya
commented
1 month ago Hey @MrBooring, Good Work πβ¨
There are some conflicts please do resolve them correctly and push back
I reviewed your code it is good to merge but please do take care of the following as well
On the verify email_verification_screen there is a
- animated container having text "verify your email" for providing better interactive user experience
- The bigger container that encapsulates the otp text field and the text around it for enhancing UI
https://github.com/AOSSIE-Org/Resonate/assets/92685647/d4f54550-d1c9-4cb4-84cb-a951f2f849b5
Rn the colour of the animated container and the text in it along with the parent container wrapping the other widgets is not set so that they are clearly visible in both dark and light themes
Play with their colours such that they are visible and look good on both the light and dark modes hence enhancing the UI
Push after making the suggested changes and resolving the conflicts carefully achieving a clean state, will merge this PR once the ones made prior to this are resolved
MrBooring
Description
This PR addresses issues with color inconsistency in several key areas of the app, including the Email ID, Password, and "New to Resonate" text in emails, the logout icon in the profile section, and the visibility of the "verify" text in verification emails. The proposed solution involves implementing a unified theme throughout the entire application. Upon approval, I estimate that this task can be completed within 1-2 days.
Fixes #230, Closes #318, #316
Type of change
How Has This Been Tested?
To verify the changes, I conducted manual testing by following these steps:
Changed the theme settings to both dark mode and light mode.
Checked if all texts and icons were clearly visible and legible in both dark and light modes. To reproduce the testing process:
Navigate to the settings or preferences section of the application. Locate the theme settings and switch between dark mode and light mode. Access the areas mentioned above, such as the login page for Email ID and Password fields, emails containing the "New to Resonate" text, the profile section for the logout icon, and verification emails for the "verify" text. Ensure that all texts and icons maintain visibility and legibility in both dark and light modes. Please let me know if you need further clarification or assistance with testing.
included screenshots below
Checklist:
Maintainer Checklist