AOSSIE-Org / Resonate

Clubhouse, but Open Source. A social voice platform.
GNU General Public License v3.0
187 stars 132 forks source link

Fix textfield tag error #309

Closed amanraval76593 closed 4 months ago

amanraval76593 commented 6 months ago

Description

This PR solves the issue with textfield_tags where error "String' has no instance named 'isValidTag" was thrown after a tag was entered in the textfield.

Changes:- Defines an inline function validateTag() within the scope of the validator. Encapsulates the validation logic within this function. Provides better encapsulation and organization of validation logic, enhancing readability and maintainability. Fixes #307

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Test manually on physical device. Before: WhatsApp Image 2024-03-21 at 11 42 56_fb6d87fc After after

Checklist:

Maintainer Checklist

amanraval76593 commented 6 months ago

I think it would be more beneficial for the overall structure and maintainability of the code if the validation logic was separated from the UI code. For instance, you could place the validateTag function in the CreateRoomController

Yes you are right,i will do it. Thanks for the suggestion.

amanraval76593 commented 6 months ago

@chandansgowda please review the changes

Aarush-Acharya commented 4 months ago

Hey @amanraval76593 this is good to go, will merge once the PR previous to this one are merged @kareemabdeen Good work with the review thank you