Closed amanraval76593 closed 4 months ago
I think it would be more beneficial for the overall structure and maintainability of the code if the validation logic was separated from the UI code. For instance, you could place the
validateTag
function in theCreateRoomController
Yes you are right,i will do it. Thanks for the suggestion.
@chandansgowda please review the changes
Hey @amanraval76593 this is good to go, will merge once the PR previous to this one are merged @kareemabdeen Good work with the review thank you
Description
This PR solves the issue with textfield_tags where error "String' has no instance named 'isValidTag" was thrown after a tag was entered in the textfield.
Changes:- Defines an inline function validateTag() within the scope of the validator. Encapsulates the validation logic within this function. Provides better encapsulation and organization of validation logic, enhancing readability and maintainability. Fixes #307
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test manually on physical device. Before: After
Checklist:
Maintainer Checklist