fixed tag controller error

amanraval76593 commented 3 months ago

Description

Fixes a bug where the TextfieldTagsController was not disposed properly, leading to resource leakage. This issue occurred when navigating away from screens that used the TextfieldTagsController without properly disposing of it.

Change: Implemented a solution by adding a new function, resetTagController(), which disposes of the previously created TextfieldTagsController instance and creates a new one before navigating to the Create Room page.

Fixes #310

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually on the physical device.

Before:-

https://github.com/AOSSIE-Org/Resonate/assets/136071018/2b51a861-f7dd-4c5e-b432-2fe120136d18

After:-

https://github.com/AOSSIE-Org/Resonate/assets/136071018/5aefa02d-821c-43d9-b069-ce834a5d3bf6

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Tag the PR with the appropriate labels

amanraval76593 commented 3 months ago

@chandansgowda please review the changes

Aarush-Acharya commented 1 month ago

Good Work @amanraval76593 🚀

This is good to merge will merge after the previously scheduled PR's are merged

vrundraval24 commented 1 month ago

Hey, @amanraval76593 this branch has merge conflicts due to the merging of previously scheduled branches. Please resolve the merge conflicts. We will wait for your response.

AOSSIE-Org / Resonate