Fix logout button color - Githubissues

AOSSIE-Org / Resonate

Clubhouse, but Open Source. A social voice platform.

GNU General Public License v3.0

171 stars 123 forks source link

Fix logout button color #317

Closed amanraval76593 closed 3 months ago

amanraval76593 commented 3 months ago

Description

This PR resolve the issue with the color of logout button in profile screen. Fixes #315

Change: Directly updating the icon color with themeController.primaryColor.value was not working when i was switching to different color.

Screenshot 2024-03-28 014238

So i used streambuilder to update the color of button as app color changes.

Screenshot 2024-03-28 014604

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually on physical device WhatsApp Image 2024-03-28 at 01 47 46_f6648e7f

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Tag the PR with the appropriate labels

amanraval76593 commented 3 months ago

I think primary color can't be null because it's already initialized in theme controller even if the user haven't choose a primary color

Yes I have corrected this in my new pr