bhawesh2002 commented 1 month ago

Description

Problem: When tiles on profile page are tapped the spalsh exceedes the visible boundry of the tiles.

Preview of the problem:

Reason: CustomCard widget(from custom_card.dart) is used for creation of tiles on ProfileScreen(from profile_screen.dart).

So when the user taps the tiles the splash generated by the Inkwell of the CustomCard widget excceedes the visible boundries of the CustomCard causing overflow.

Fix: Fixed splash overflow issue by setting clipBehaviour to clip.antiAlias in Card widget of CustomCard widget.

Fixes

284: The splash radius of buttons on the profile page exceeds the border

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

The changes have been tested on android emulator(API 33 and 32) and do not cause any additional issues.

Screenshot after Fix

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[X] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Tag the PR with the appropriate labels

AyaNady17 commented 1 month ago

Good Work @bhawesh2002 🚀

This is good to merge will merge after the previously scheduled PR's are merged

vrundraval24 commented 1 month ago

Hey, @bhawesh2002 please resolve the merge conflicts. Then we will merge this PR.

bhawesh2002 commented 1 month ago

@vrundraval24 I have resolved the merge conflicts