AOSSIE-Org / Resonate

Clubhouse, but Open Source. A social voice platform.
GNU General Public License v3.0
171 stars 123 forks source link

Fix: Make login screen responsive by using height value from UiSizes #324

Closed bhawesh2002 closed 1 month ago

bhawesh2002 commented 1 month ago

Description

Problem: Bottom overflowed error when user is on login screen.

Preview of the problem: Screenshot from 2024-05-14 09-28-07

Reason: Hard Coded value of height=780 is used for setting height(line 38 of login_screen.dart) of the Container containing login screen elements

Fix: Set height=UiSizes.height_780 to implement responsive design instead of using hard coded values

Fixes

287 : Bug:- Bottom overflowed error on login screen

Type of change

Please delete options that are not relevant.

The changes are tested on Android Emulator (API 33: Pixel 8 Pro) and on Moto g40 Fusion(API 32). The changes fixes the bug without raising any additional errors

Preview After Fix: Screenshot from 2024-05-14 09-33-29

Checklist:

Maintainer Checklist

AyaNady17 commented 1 month ago

Good Work @bhawesh2002 🚀

This is good to merge will merge after the previously scheduled PR's are merged