search

AOSSIE-Org / Resonate

Clubhouse, but Open Source. A social voice platform.
GNU General Public License v3.0
192 stars 141 forks source link

Picture Image resolution too high #358

Open Aarush-Acharya opened 1 week ago

Aarush-Acharya commented 1 week ago

🐛 Describe the bug

The picture being used as an emoji for no connection dialog and no room dialog is of 1800 x 1800 resolution which is very high. The resolution makes the current size of the Images to be around 4 mb each which is too much

Scale the images down to 10Kb. If the image resolution falls below acceptance once you reach this image size then just simply replace it with a Text Emoji but the size should be around 10Kb

M4dhav commented 1 week ago

Hello @Aarush-Acharya, As this issue is unassigned, I would like to work on it. I have past experience in working on similar issues and contributing to open source in general and I think I could get this done quickly.

If possible, please assign. Thank You

xkaper001 commented 1 week ago

Hi @Aarush-Acharya ,

I noticed that this issue is unassigned, and I'd love to work on it! I'm familiar with the technology used in this project and I believe I can help resolve it.

Could you please assign this issue to me?

Thank you!

Aarush-Acharya commented 1 week ago

hey @xkaper001 I am assigning the issue to you. Make sure you take care of the trade off (i.e reduce while quality still remains acceptable)

xkaper001 commented 1 week ago

hey @xkaper001 I am assigning the issue to you. Make sure you take care of the trade off (i.e reduce while quality still remains acceptable)

Sure :)

Aarush-Acharya commented 1 week ago

Hey I have merged a PR please pull before working further and make sure to work on the dev branch

Aarush-Acharya commented 1 week ago

Hey new PR merged please pull before moving forward

maiHydrogen commented 4 days ago

Hi @Aarush-Acharya I am new to this opensource thing but I am quite familiar with the flutter + firebase things as i saw this issue labelled as good first issue i thought i should give it a try too. can i work on it?

Aarush-Acharya commented 3 days ago

hey @maiHydrogen, @xkaper001 is already working on it,

hey @xkaper001, any progress update ?

xkaper001 commented 3 days ago

hi @Aarush-Acharya, Yes I've almost completed the work to fix this issue. Will send a PR latest by tomorrow.

Aarush-Acharya commented 3 days ago

@xkaper001, got it

xkaper001 commented 2 days ago

hey @Aarush-Acharya, I face the following

  1. When I compress the image down to 10kb, The image becomes pixelated something like this,

dizzy-face-10kb no_rooms_10kb which worsens the user experience.

  1. Compressing it to somewhere around 25 and 29kb seems fine to me, like

no_connection_24 no_rooms_29

  1. Also the text emoji alternative doesn't work, it also is blur at that level screenshot

What are your views? Which path should I go? I propose to use 2nd method where compressing it to less than 30 kb seems fine to me.

Aarush-Acharya commented 1 day ago

Hey @xkaper001, second method feels fine, though our initial target was to keep them below 10kb

I feel it should be fine but do research a little more on it and let me know what better could be done for now let's go with the 30 on but please do look into it more

There isn't a hard requirement to use the emojis only we can go with illustrations as well but then we would have to update the colour of the illustration according to the primary colour of the theme

Could you research more on this next ? It is possible to do that

xkaper001 commented 1 day ago

Hey @Aarush-Acharya, I found out a way to compress images down to 10kb to fit our needs :) Also I choose to stick to these two emojis coz they're elegant imo, and fits well with our simplistic UI.

All the below emoji's are less than 10KB

Here are the new images h2 h

Also I propose to change this emoji png with a new one, reason: The pensive face emoji looks kinda depressed/a little too sad imo (totaly my opinion). I'll go with what you say. sad to h

Final Screenshots/ Output

image image