search

AOSSIE-Org / website

AOSSIE Offical Website
https://aossie-org.github.io/website/
MIT License
25 stars 144 forks source link

change twitter bird logo to 'X' logo in the footer section #207

Open ashhcoder opened 2 months ago

ashhcoder commented 2 months ago

Change the twitter bird logo to twitter 'X' logo in the footer section. For reference:

Screenshot from 2024-08-14 01-39-09

crazyshrut commented 2 months ago

hey @ashhcoder can you assign this issue to me?

Harshinireddy05 commented 2 months ago

Hey @ashhcoder I would like to work on this issue. Can you please assign this issue to me?

keshav861 commented 2 months ago

@ashhcoder the twitter logo should be replaced for the main body part too image

keshav861 commented 2 months ago

@ceilican i have pulled a request for the following changes of the twitter logo to "X" logo for the main body and the footer part if you think the pull request is correct kindly merge it as per your convenience.

sankshaypusa commented 2 months ago

HI i have changed the twitter logo and replaced it with new one,kindly check my Pull request #PR RAISED

Vegadjay commented 2 months ago

@keshav861 Is Logo changed from your approach ?

keshav861 commented 2 months ago

@Vegadjay yes logo is changing from my approach

Vegadjay commented 2 months ago

@keshav861 From where you get this logo bcz this is use react-fontawsome library and that library does not contain X logo.. from where you get this logo

keshav861 commented 2 months ago

@Vegadjay ya i got this the font awesome library doesn't support for the fontawesome V5. react-fontawesome is old library. As of now i was directly using the fontawesome official react component as in node_module i added that component so thats why i think it is working and may be it wont work on it. we have to change the react-fontawesome library to react-icons library this may solve the issue or just add add a javascript file to the html file then can use this directly these are the 2 best ways to overcome this problem i think so....

ShivaGheji commented 1 month ago

Hi, I fixed the issue (#265) with the Twitter logo in the body/footer section. the new X logo wasn't available in the old version of FontAwesome, so i updated the FontAwesome packages to the latest version and replaced the logo. It's now looking good. I've submitted a PR with the changes (#267), and i've attached a screenshot for reference. Please review it, and if everything looks good, kindly merge my PR. If there are any issues, please let me know, and I'll make the necessary changes.