Closed jonathan-longe closed 1 year ago
A couple of suggested changes for your consideration:
- update install.bash to use "docker compose" instead of "docker-compose". My understanding is the "docker-compose" has been deprecated. See: https://stackoverflow.com/a/66516826
- create an uninstall.bash script to remove the docker images and volumes. There's already an uninstall.bat we should have bash script too.
- finally modify .gitignore to exclude secrets and build artifacts from this repository.
That''s great Jonathan.. We were planning to include these, let me test it once and will update
@kiran-aot @abilpraju-aot @formsflow-product-admin please look into this MR, changes looks good cc @alanraju-aot
Currently we are closing this as we have got these changes.
A couple of suggested changes for your consideration: