AOT-Technologies / forms-flow-ai-deployment

Deployment base for forms-flow-ai
Apache License 2.0
7 stars 26 forks source link

Key name updated as per script file #27

Closed uzrnem closed 1 year ago

uzrnem commented 1 year ago

In scripts key used was KEYCLOAK_ADMIN_USERNAME and in docker file it was KEYCLOAK_ADMIN_USER

uzrnem commented 1 year ago

@sreehari-aot can you help me get second approval. cc @alanraju-aot @auslin-aot

sreehari-aot commented 1 year ago

@sreehari-aot can you help me get second approval. cc @alanraju-aot @auslin-aot

@uzrnem Really appreciate your contribution 👍 , our team will verify the changes. @alanraju-aot pls have a check.

uzrnem commented 1 year ago

@sreehari-aot can you help me get second approval. cc @alanraju-aot @auslin-aot

@uzrnem Really appreciate your contribution +1 , our team will verify the changes. @alanraju-aot pls have a check.

@sreehari-aot Mention not, Its my duty.

uzrnem commented 1 year ago

can anyone please merge this? I am not able to merge as I dont have write access cc @abilpraju-aot @alanraju-aot @sreehari-aot

abhilash-aot commented 1 year ago

Good Catch @uzrnem . The env you have pointed out with the typo "KEYCLOAK_ADMIN_USERNAME" is not used anymore in webapi environment from v4.0.5. So basically the script need the modification rather than the env keys. We have already been working on that and minimized the env variable keys. Will be releasing the updated script by next week. Closing this PR for now