AObuchow / Eclipse-Spectrum-Theme

Eclipse plugin which adds the Spectrum theme.
https://marketplace.eclipse.org/content/spectrum-dark-theme
Eclipse Public License 2.0
23 stars 5 forks source link

Tree Item Arrows are invisible #123

Closed schaarda closed 4 years ago

schaarda commented 4 years ago

image

On Windows 7 the triangles on tree items seem to be black on black and are therefore only barely visible which makes this theme really hard to use. There was a similar error in 2015 reported against the Eclipse Dark Theme : https://bugs.eclipse.org/bugs/show_bug.cgi?id=434201 Maybe this contains hints on a solution for this theme as well.

AObuchow commented 4 years ago

@schaarda thank you very much for reporting & for the relevant upstream bug. I’ll work on a fix and keep you updated :)

PyvesB commented 4 years ago

Nowadays, Platform solves this by relying on native Windows dark theme elements if I recall correctly, and has therefore dropped the custom drawing approach from bug 434201. Native dark theme is probably not available on old Windows 7, that's why tree arrows don't render properly. Worth noting that Eclipse no longer supports Windows 7 (neither does Microsoft), you can expect other things to not work as expected.

AObuchow commented 4 years ago

@PyvesB hm that's problematic, as this issue might not be easily fixable/supportable in Spectrum Theme. @schaarda does this issue also affect the standard dark theme? And what version of Eclipse IDE are you using?

schaarda commented 4 years ago

I'm currently using Eclipse 2020-06. At least on 2019-12 the standard dark theme did work as expected. I've not tried Standard Dark with Eclipse 2020-06 but will do so once I return (next Wednesday).

30.07.2020 19:04:59 Andrew O. notifications@github.com:

@PyvesB[https://github.com/PyvesB] hm that's problematic, as this issue might not be easily fixable/supportable in Spectrum Theme. @schaarda[https://github.com/schaarda] does this issue also affect the standard dark theme? And what version of Eclipse IDE are you using?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub[https://github.com/AObuchow/Eclipse-Spectrum-Theme/issues/123#issuecomment-666528146], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAK7J2AN4YUN4PICGXAK533R6GR3RANCNFSM4PNJOB2A]. [https://github.com/notifications/beacon/AAK7J2CTDBXI4ZVT6VHSVVLR6GR3RA5CNFSM4PNJOB2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE65GTEQ.gif]

AObuchow commented 4 years ago

@schaarda thanks for the updated info, let us know how the 2020-06 platform dark theme is when you have a moment

schaarda commented 4 years ago

Lesson of the day: Don't change two things at once. It seems to be a regression in Eclipse. The standard dark theme in 2020-06 has the same behavior as described above. Eclipse 2020-03 standard dark theme works as expected with visible triangles. Alas I could not try Spectrum with Eclipse 2020-03 because of unsatisfied dependencies. When I let the installer do it's problem solving magic, it simply upgrades me to 2020-06.

So this is an Eclipse bug indeed. But I doubt they're gonna fix this given the age of Win 7. So I'm going to close this bug, thanks for your help.