search

AObuchow / Sample-Commander

Orthodox File Manager for organizing audio files, written in Java using Eclipse RCP
Eclipse Public License 2.0
3 stars 0 forks source link

Change feature name #30

Closed AObuchow closed 4 years ago

AObuchow commented 4 years ago

The feature name is currently set to "featureName". It should be set to something like "Sample Commander"

AObuchow commented 4 years ago

@ingomohr I saw there's a feature.properties, which defines the featureName, but for some reason it's not being used?

To reproduce, build the project with mvn verify, then install the plugin locally. The feature name will say "featureName"

ingomohr commented 4 years ago

@ingomohr I saw there's a feature.properties, which defines the featureName, but for some reason it's not being used?

To reproduce, build the project with mvn verify, then install the plugin locally. The feature name will say "featureName"

@AObuchow Hm, I'll check on that.

ingomohr commented 4 years ago

@AObuchow Yep, you're right. The name is not resolved from the feature.propertiesfile. I'll create a PR for this.

ingomohr commented 4 years ago

@AObuchow Sorry ;) - I should've tested this better before.

AObuchow commented 4 years ago

@ingomohr no worries, thank you for the quick fix :)