search

AObuchow / Sample-Commander

Orthodox File Manager for organizing audio files, written in Java using Eclipse RCP
Eclipse Public License 2.0
4 stars 0 forks source link

Inline rename files in FileManager #49

Closed AObuchow closed 4 years ago

AObuchow commented 4 years ago

Fix #47

Signed-off-by: Andrew Obuchowicz aobuchow@redhat.com

AObuchow commented 4 years ago

This still has the same issue as the project explorer upstream, and would probably need a similar fix as detailed here

AObuchow commented 4 years ago

I think this also needs a rename handler so that rename can be started when pressing F2

AObuchow commented 4 years ago

This still has the same issue as the project explorer upstream, and would probably need a similar fix as detailed here

Basically, the name column's cell editor needs a TextActionHandler

AObuchow commented 4 years ago

This still has the same issue as the project explorer upstream, and would probably need a similar fix as detailed here

Basically, the name column's cell editor needs a TextActionHandler

TextActionHandler seems to be based around Actions (e3) and not Command's (e4).

I mirrored the implementation of TextActionHandler for commands, although this could be made more generic in the future (for use upstream).

The idea is that when a cut/copy/paste/etc command is run, it calls the editor's cut/copy/paste/etc implementation, which first checks if the viewer's cell editor is active. If it's active, the command is handled by the cell editor, otherwise the usual editors implementation is called.