search

AOtools / aotools

A useful set of tools for Adaptive Optics in Python
GNU Lesser General Public License v3.0
109 stars 43 forks source link

Tidying function names ready for v1.0 #50

Closed matthewtownson closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will decrease coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   95.18%   94.98%   -0.21%     
==========================================
  Files          25       24       -1     
  Lines        1226     1176      -50     
==========================================
- Hits         1167     1117      -50     
  Misses         59       59
Impacted Files Coverage Δ
aotools/turbulence/slopecovariance.py 98.29% <ø> (-0.02%) :arrow_down:
aotools/image_processing/__init__.py 100% <ø> (ø) :arrow_up:
aotools/functions/zernike.py 96.89% <100%> (ø) :arrow_up:
aotools/image_processing/centroiders.py 100% <100%> (ø) :arrow_up:
aotools/functions/_functions.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f55ac77...0a39916. Read the comment docs.

andrewpaulreeves commented 5 years ago

Exciting to get around to v1.0!

Perhaps I've missed it, but are the old function names deprecated or are we killing them? Also, some functions from _functions have gone, but I can't see them elsewhere, are they still around?

matthewtownson commented 5 years ago

They have been deprecated. They should all still exist, some of them have moved around though. e.g. azi_avg moved from _functions to image_processing.

andrewpaulreeves commented 5 years ago

Seems reasonable to me - though it best to check though. Merging....!