AOtools / aotools

A useful set of tools for Adaptive Optics in Python
GNU Lesser General Public License v3.0
109 stars 43 forks source link

Fix bug, where seed in infinite screen had no effect #64

Closed andrewpaulreeves closed 3 years ago

andrewpaulreeves commented 3 years ago

Because ft_phase_screen will use a system random number generator when seed is None, some seed must be given to make it repeatable.

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (75b91b0) into master (c93ef2d) will decrease coverage by 0.04%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   92.61%   92.57%   -0.05%     
==========================================
  Files          25       25              
  Lines        1314     1319       +5     
==========================================
+ Hits         1217     1221       +4     
- Misses         97       98       +1     
Impacted Files Coverage Δ
aotools/turbulence/infinitephasescreen.py 85.89% <80.00%> (-0.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c93ef2d...75b91b0. Read the comment docs.

matthewtownson commented 3 years ago

Sorry I forgot about this, thanks for fixing.