search

AOtools / aotools

A useful set of tools for Adaptive Optics in Python
GNU Lesser General Public License v3.0
109 stars 42 forks source link

numpy 1.21 will require an int for factorial #76

Closed andrewpaulreeves closed 2 years ago

andrewpaulreeves commented 2 years ago

This would break some Zernike making functions, which give floats (even though they are always ints). Now make them ints explicitly.

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (3aac670) into master (5bd74bf) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          42       42           
  Lines        2014     2014           
=======================================
  Hits         1849     1849           
  Misses        165      165
Impacted Files Coverage Δ
aotools/functions/zernike.py 96.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bd74bf...3aac670. Read the comment docs.