search

AOtools / aotools

A useful set of tools for Adaptive Optics in Python
GNU Lesser General Public License v3.0
109 stars 43 forks source link

added exception in the case of KL modes without central obsc #84

Closed ojdf closed 2 years ago

ojdf commented 2 years ago

The method used to compute KL modes is only valid for annular apertures, but nothing stops you from using ri=0 (0 central obscuration), resulting in artefacts close to the centre of the modes. Just added a check and exception to make sure this cannot be done.

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (2012503) into main (76dd3dc) will decrease coverage by 0.04%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   92.10%   92.06%   -0.05%     
==========================================
  Files          42       42              
  Lines        1988     1990       +2     
==========================================
+ Hits         1831     1832       +1     
- Misses        157      158       +1
Impacted Files Coverage Δ
aotools/functions/karhunenLoeve.py 92.13% <50.00%> (-0.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76dd3dc...2012503. Read the comment docs.