AOtools / aotools

A useful set of tools for Adaptive Optics in Python
GNU Lesser General Public License v3.0
109 stars 42 forks source link

r0 in m or cm? #88

Closed andrewpaulreeves closed 1 year ago

andrewpaulreeves commented 2 years ago

I've been using some functions from atmos_conversions for converting r0 -> cn2 and back. Sometimes r0 is listed in the docs as being is cm, sometimes in m. Is it really in cm sometimes? From a quick look at the equations I would guess its mostly in m.

matthewtownson commented 2 years ago

Is it easy for you to update the docstrings in the functions? If not, then I can sort it in the next month or so.

ojdf commented 2 years ago

it definitely returns and expects r0 in m, the docstrings for r0_to_cn2 and r0_to_seeing are wrong