Pyramid WFS - Githubissues

AOtools / soapy

A Python Adaptive Optics Simulation

GNU General Public License v3.0

85 stars 32 forks source link

Pyramid WFS #124

Closed AurelieMagniez closed 2 years ago

AurelieMagniez commented 2 years ago

Add a new version of the Pyramid WFS (PWS), change the conf parse file to add more input parameters for the PWS. Add a new conf file example to run a PWS

andrewpaulreeves commented 2 years ago

Hi @AurelieMagniez - looks really good!

2 Small points:

you have a "photons per mag" type function in teh pyramid WFS module. Is this something that can be imported from aotools, or put in a seperate library so it might be useful elsewhere?
Could you add a very quick test in the "tests" directory, that loads your WFS, runs it and if your feeling really ambitious, checks against some known phase / measurement?

ojdf commented 2 years ago

as far as I can see, the photons_per_mag is not actually used anywhere so can probably be removed?

AurelieMagniez commented 2 years ago

Hi both,

Yes, the photon_per_mag is a function I left because I am using photon counting in my project. I forgot to delete it for this release, unless people are interested in photon counting?

As for the tests, do you want me to do something on the model of "testWfs.py"?

ojdf commented 2 years ago

@andrewpaulreeves I've added (or rather uncommented) the pyramid tests, and they seem to work...

andrewpaulreeves commented 2 years ago

All looks good!