search

AP-Hunt / FicsitRemoteMonitoringCompanion

A companion app to the Ficsit Remote Monitoring mod for Satisfactory
23 stars 9 forks source link

Separate the exporter in its own repo, please #19

Closed surdaft closed 11 months ago

surdaft commented 1 year ago

Would it be possible to move the exporter/companion go section into its own repo, so that it can be used as a library within other projects.

https://github.com/AP-Hunt/FicsitRemoteMonitoringCompanion/tree/main/Companion

https://github.com/surdaft/FicsitRemoteMonitoringCompanion/tree/main/ https://github.com/surdaft/ficsit-exporter

It doesn't necessarily need to be called the same thing and could be added as a sub-module. However the thoughts are that I have a wrapper which takes your exporter work, and then wraps it with a /probe?target={address} instead. This allows me to use the exporter with any target I want, instead of a fixed target. I feel as though it may not be within the needs of your project and so I didn't think a PR would be appropriate for it, but might also help other projects to allow access to these modules.

I am possibly a potato too though, and so I might have missed how to import a module from a subdirectory of a project, without using a go.mod replace method.

AP-Hunt commented 1 year ago

Hi Jack,

I'm definitely not against making my code into something reusable by others, but it'll take me a few days to properly address the issue because I don't currently have access to a dev environment for it.

On Thu, Sep 7, 2023, 21:22 SurDaft - Jack Stupple @.***> wrote:

Would it be possible to move the exporter/companion go section into its own repo, so that it can be used as a library within other projects.

https://github.com/AP-Hunt/FicsitRemoteMonitoringCompanion/tree/main/Companion

https://github.com/surdaft/FicsitRemoteMonitoringCompanion/tree/main/ https://github.com/surdaft/ficsit-exporter

It doesn't necessarily need to be called the same thing and could be added as a sub-module. However the thoughts are that I have a wrapper which takes your exporter work, and then wraps it with a /probe?target={address} instead. This allows me to use the exporter with any target I want, instead of a fixed target. I feel as though it may not be within the needs of your project and so I didn't think a PR would be appropriate for it, but might also help other projects to allow access to these modules.

I am possibly a potato too though, and so I might have missed how to import a module from a subdirectory of a project, without using a go.mod replace method.

— Reply to this email directly, view it on GitHub https://github.com/AP-Hunt/FicsitRemoteMonitoringCompanion/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANKTOQCTOGVSFZ37KBNMCTXZIUG3ANCNFSM6AAAAAA4PNHLTE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

AP-Hunt commented 1 year ago

Hi Jack,

I haven't forgotten about this, I just haven't been able to devote any time to it. If you'd be interested, I'd be happy to review a PR that separates the relevant code into its own Go module, which can be imported from the same repo (e.g. github.com/AP-Hunt/FicsitRemoteMonitoringCompaion/exporter).

surdaft commented 1 year ago

I have done some tinkering with it, I just have been doing bits and bobs elsewhere.