search

AP-Students / website

1 stars 17 forks source link

resolve sidebar Firefox issue (#59) #60

Closed elijah-wright closed 3 months ago

elijah-wright commented 3 months ago

this PR rewrites the sidebar component and fixes an issue in which the button for the sidebar wouldn't appear on Firefox after closing for the following reason:

the reason for this is because Firefox doesn't animate display: none as a discrete property, because it would cancel out the animation. that behavior may change with transition-behavior: allow-discrete, which will be included in Firefox 129 next week. the solution is to animate the content in the sidebar to position: absolute, which has issues but works across Firefox and Chromium browsers

elijah-wright commented 3 months ago

I'm going to close this, bd7 mentioned that we could just fix the issue and worry about a rewrite later. as much as I do want to rewrite the sidebar including the old code with the new code isn't going to work