search

APDevTeam / Movecraft-Cannons

Movecraft & Cannons Integration
GNU General Public License v3.0
6 stars 9 forks source link

Working cannon reports #11

Closed TylerS1066 closed 2 years ago

TylerS1066 commented 3 years ago

I'm opening this issue so people can report fully working Movecraft-Cannons installs. This will allow us to compare these reports to #9 and #10 to find the differences and track down these annoying bugs,

TylerS1066 commented 3 years ago

One problem with cannon rotation was that the CraftRotateEvent could be cancelled by other plugins with listeners operating at a higher priority. As a result, Movecraft-Cannons would rotate the cannons data even though the craft itself was ultimately prevented from rotating. To resolve this, the CraftRotateEvent listener was set to run at EventPriority.MONITOR with ignoreCancelled set to true.

This is a good point, thank you for letting me know.

With translation, I think the problems stemmed from the use of CraftPreTranslateEvent

Hmm, that is a good point. I'm going to ask CC if there is a proper method to do this in the current API, or if we need to expand the API as you suggest.

TylerS1066 commented 2 years ago

Since there have been no reports of problems in 3 months, I am going to mark this as resolved!