search

APDevTeam / Movecraft-Combat

Movecraft Combat Addon
GNU General Public License v3.0
7 stars 17 forks source link

Particle Tracers Delay Problem #104

Closed MysteryTimeTrav closed 1 year ago

MysteryTimeTrav commented 1 year ago

The effect given to the particle tracers is delayed by about 20 ticks after the explosion actually occurs

Suggestion would be to have it appear as soon as the explosion occurs with no delay if possible so particle tracers could be used as a way to see the effects of cannons further out

https://github.com/APDevTeam/Movecraft-Combat/blob/e1f391c1078d919d745f1264c1c6d61a85380c2b/src/main/java/net/countercraft/movecraft/combat/features/tracers/TNTTracers.java#L157

TylerS1066 commented 1 year ago

The reason I added that delay was so the particles can show up after the explosion has cleared.

MysteryTimeTrav commented 1 year ago

The problem is that you wouldn't see the explosion past a certain distance anyway as while Minecraft renders TNT entities out to that range, it doesn't render the particles of the explosion

this means that the tracer particle explosion indicator appears awkwardly late after a crater does

Movecraft-Combat already has a setting to disable the explosion indicator within a certain radius which would allow for protection against redundancy if the explosion occurs within normal Minecraft particle rendering TracerMinDistance: 15 # Minimum distance at which glowstone tracers are spawned on explosion

But if this delay is necessary in certain cases and uses of the particle tracers, would it be possible for a config setting to be added to adjust the delay?

TylerS1066 commented 1 year ago

Adding a config for the delay should be simple

MysteryTimeTrav commented 1 year ago

Something I also noticed is that sometimes the impact particles don't show up but the tracers do. Is there a limit to how many can spawn? I'm not sure if this is the case because sometimes they don't appear even when dealing with pretty small amounts of TNT.

TylerS1066 commented 1 year ago

Hmm, I'm not sure why they wouldn't show up. The only reason I've noticed so far has been that the explosion particles obstruct the view.

goodroach commented 1 year ago

https://github.com/APDevTeam/Movecraft-Combat/blob/e1f391c1078d919d745f1264c1c6d61a85380c2b/src/main/java/net/countercraft/movecraft/combat/features/tracers/TNTTracers.java#LL164C1-L164C1

This is the line yes? All I have to do is just add a setting option for it?

TylerS1066 commented 1 year ago

Yup