search

APDevTeam / Movecraft-Combat

Movecraft Combat Addon
GNU General Public License v3.0
7 stars 17 forks source link

[Feature] Flammability override #131

Closed DerToaster98 closed 3 months ago

DerToaster98 commented 3 months ago

Similar to blast resistance override, this allows one to make ANY block flammable.

Tested on 1.19.3

Could not find a button for "allow edits from maintainers" sadly

DerToaster98 commented 3 months ago

Addressed your previous points in the latest few commits

DerToaster98 commented 3 months ago

Reworked the entire thing. It is now one class for all block property overrides, haven't tested it yet

DerToaster98 commented 3 months ago

Seems like i broke blast resistance when unifying both, will need to fix that first...

DerToaster98 commented 3 months ago

Fixed, now we have a working unified version

TylerS1066 commented 3 months ago

One thing I forgot to mention, you should put an example in the config. I'd suggest maybe make scaffolding super flammable?

DerToaster98 commented 3 months ago

One thing I forgot to mention, you should put an example in the config. I'd suggest maybe make scaffolding super flammable?

Sure, in my tests i used obsidian to make it as flammable as wood, we can just comment out the line. But i think using a normally non flammable block as example works best (scaffolding by default is flammable)

TylerS1066 commented 3 months ago

Build is failing due to an unrelated Movecraft change, I'll address that on main and let you merge it in to get a passing build.