APDevTeam / Movecraft-Combat

Movecraft Combat Addon
GNU General Public License v3.0
7 stars 17 forks source link

Fix fire obstruction when Fireball Penetration is enabled #47

Closed drfiveminusmint closed 3 years ago

drfiveminusmint commented 3 years ago

Previously, Fireball Penetration would cause the onBlockIgnite function to return if it did not find a block to replace with air. This pull request fixes that by segregating the Fireball Penetration code to a doFireballPenetration function.

TylerS1066 commented 3 years ago

This has been tested, correct?

drfiveminusmint commented 3 years ago

It's been tested on 1.10.2 , I can test it on 1.14 if necessary but the code is copy-pasted so nothing version-specific should have changed