APDevTeam / Movecraft-Combat

Movecraft Combat Addon
GNU General Public License v3.0
7 stars 17 forks source link

Fireballs Won't Despawn #74

Closed MysteryTimeTrav closed 3 years ago

MysteryTimeTrav commented 3 years ago

An issue that I've found is that fire charges fired from dispensers when running the latest version of Movecraft Alpha and Movecraft Combat don't despawn after the set period of time and continue on infinitely. No error is produced in the server logs or on console when firing firecharges. Latest versions downloadable on GitHub were used.

Movecraft Combat Config


Locale: "en" # Language file to load, currently the plugin comes with en and no, but you can add your own custom language as well.

### Stock features moved from Movecraft

# AA Directors
AADirectorDistance: 50 # Max range at which fireballs will be redirected
AADirectorRange: 120 # Max range at which it will direct to a block vs in the general direction
AADirectorsAllowed: # List of string names to craft types that are allowed to use AA Directors
  - "Airship"
  - "SubAirship"
  - "Lightairship"
  - "Turret"
  - "Car"
  - "Ship"
  - "Submarine"
  - "Hvyairskiff"

# Cannon Directors
CannonDirectorDistance: 100 # Max range at which TNT will be redirected
CannonDirectorRange: 120 # Max range at which it will direct to a block vs in the general direction
CannonDirectorsAllowed: # List of string names to craft types that are allowed to use Cannon Directors
  - "Airship"
  - "SubAirship"
  - "Lightairship"
  - "Airskiff"
  - "Bigairskiff"
  - "Turret"
  - "Car"
  - "Ship"
  - "Submarine"
  - "Factory"

# Directors
DirectorTool: FEATHER # Material name for director control.
TransparentBlocks: # List of MATERIAL_NAMES which are ignored for directing.  See https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Material.html for a full list.
  - AIR
  - GLASS
  - GLASS_PANE
  - REDSTONE_WIRE
  - COMPARATOR
  - REPEATER
  - LADDER
  - STAINED_GLASS
  - BLACK_STAINED_GLASS
  - BLACK_STAINED_GLASS_PANE
  - GRAY_STAINED_GLASS
  - GRAY_STAINED_GLASS_PANE
  - LIGHT_GRAY_STAINED_GLASS
  - LIGHT_GRAY_STAINED_GLASS_PANE
  - WHITE_STAINED_GLASS
  - WHITE_STAINED_GLASS_PANE
  - SPRUCE_TRAPDOOR
  - BIRCH_TRAPDOOR
  - IRON_BARS
  - REDSTONE_WIRE
  - IRON_TRAPDOOR
  - TRAP_DOOR
  - NETHER_BRICK_STAIRS
  - LEVER
  - STONE_BUTTON
  - OAK_BUTTON
  - SPRUCE_BUTTON
  - BIRCH_BUTTON
  - JUNGLE_BUTTON
  - ACACIA_BUTTON
  - DARK_OAK_BUTTON
  - STONE_BRICK_STAIRS
  - STONE_BRICK_SLAB
  - SMOOTH_STONE_SLAB
  - OAK_WALL_SIGN
  - OAK_SIGN
  - SPRUCE_WALL_SIGN
  - SPRUCE_SIGN
  - BIRCH_WALL_SIGN
  - BIRCH_SIGN
  - JUNGLE_WALL_SIGN
  - JUNGLE_SIGN
  - ACACIA_WALL_SIGN
  - ACACIA_SIGN
  - DARK_OAK_WALL_SIGN
  - DARK_OAK_SIGN
  - GRAY_CARPET
  - LIGHT_GRAY_CARPET
  - TORCH
  - WALL_TORCH
  - REDSTONE_TORCH
  - REDSTONE_WALL_TORCH

# Contact Explosives
EnableContactExplosives: true # Enable TNT contact explosives

# Durability Override
DurabilityOverride: # List of block IDs: ignore percent
  END_STONE: 80
  END_STONE_BRICKS: 85
  END_STONE_BRICK_STAIRS: 85
  END_STONE_BRICK_SLAB: 85
  END_STONE_BRICK_WALL: 85
  LADDER: 80
  DISPENSER: 80
  HONEY_BLOCK: 80
  SLIME_BLOCK: 80
  BARREL: 60
  CHEST: 60
  OAK_BUTTON: 240
  SPRUCE_BUTTON: 240
  BIRCH_BUTTON: 240
  JUNGLE_BUTTON: 240
  ACACIA_BUTTON: 240
  DARK_OAK_BUTTON: 240
  STONE_BUTTON: 240
  LEVER: 240
  REDSTONE: 240
  REPEATER: 240
  REDSTONE_TORCH: 240
  REDSTONE_WALL_TORCH: 240
  PISTON: 200
  COMPARATOR: 240
  OBSERVER: 99
  ALL_STAINED_GLASS: 70
  STICKY_PISTON: 180
  ALL_SIGN: 180
  REDSTONE_WIRE: 180
  OAK_WALL_SIGN: 180
  SPRUCE_WALL_SIGN: 180
  BIRCH_WALL_SIGN: 180
  JUNGLE_WALL_SIGN: 180
  OAK_SIGN: 180
  SPRUCE_SIGN: 180
  BIRCH_SIGN: 180
  JUNGLE_SIGN: 180
  WHITE_CONCRETE: 82
  ORANGE_CONCRETE: 82
  MAGENTA_CONCRETE: 82
  LIGHT_BLUE_CONCRETE: 82
  YELLOW_CONCRETE: 82
  LIME_CONCRETE: 82
  PINK_CONCRETE: 82
  GRAY_CONCRETE: 82
  LIGHT_GRAY_CONCRETE: 82
  CYAN_CONCRETE: 82
  PURPLE_CONCRETE: 82
  BLUE_CONCRETE: 82
  BROWN_CONCRETE: 82
  GREEN_CONCRETE: 82
  RED_CONCRETE: 82
  BLACK_CONCRETE: 82
  dirt: 95
  grass_block: 95
  podzol: 95
  grass_path: 95
  coarse_dirt: 95
  farmland: 95
  sand: 88
  sandstone: 88
  bricks: 88
  brick_stairs: 88
  stone_bricks: 88
  chiseled_stone_bricks: 88
  polished_andesite: 88
  iron_block: 86
  polished_basalt: 95
  polished_blackstone_stairs: 95
  polished_blackstone_bricks: 95
  polished_blackstone_brick_stairs: 95
  smooth_sandstone_stairs: 95
  stone_stairs: 95
  polished_andesite_stairs: 95
  cut_red_sandstone: 95
  chiseled_red_sandstone: 95
  polished_granite: 95
  cut_sandstone: 95
  chiseled_sandstone: 95
  smooth_stone: 95

# Fireball Lifespan
FireballLifespan: 5 # Lifespan of fireballs in seconds

# TNT Tracers
TracerRateTicks: 3.5 # Rate at which tracers are spawned on the path of flying TNT
TracerMinDistance: 60 # Minimum distance at which glowstone tracers are spawned on explosion
TracerParticles: CAMPFIRE_COSY_SMOKE # Particle to use for particle tracers  See https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Particle.html for options.
ExplosionParticles: EXPLOSION_HUGE # Particle to use for particle tracer explosions

### Custom features

# Damage Tracking
EnableFireballTracking: false # Enable tracking and recording of fireballs (higher lag than other tracking methods)
EnableTNTTracking: false # Enable tracking and recording of TNT damage (please read the wiki page before enabling!)
EnableTorpedoTracking: false # Enable tracking and recording of Torpedo damage
DamageTimeout: 300 # Timeout for damages in seconds

# Combat Release Tracking
EnableCombatReleaseTracking: false # Enable tracking of combat releasing
EnableCombatReleaseKick: false # Enable combat release kick, overriden to true if CombatReleaseBanLength isn't 0
CombatReleaseBanLength: 0 # Length of combat release ban in seconds, set to 0 to disable
CombatReleaseScuttle: false # Enable scuttling of crafts when combat released

# Anti-Player Radar
EnableAntiRadar: false # Enable invisibility for craft pilots to nullify minimap "player radar" modes

# Fire Behavior
EnableFireballPenetration: true # Randomly replace blocks with fire when they are struck by fireballs.
AddFiresToHitbox: true # Add fires lit on the surface of a craft to its hitbox so they don't obstruct it.

# TNT Translocation Behavior
ReImplementTNTTranslocation: false # Re-implement TNT translocation in 1.11+, ignored in 1.10```

--------------------This Is A Separate File For Movecraft's Config below Here---------------------------

```Locale: en
CompatibilityMode: false
SinkRateTicks: 20
SinkCheckTicks: 100
TracerRateTicks: 5
TracerMinDistance: 60
PilotTool: STICK
ManOverboardTimeout: 860
ManOverboardDistance: 5000
FireballLifespan: 5
ProtectPilotedCrafts: true
DisableSpillProtection: false
DisableIceForm: true
RequireCreatePerm: false
TNTContactExplosives: true
DisableCrates: true
FadeWrecksAfter: 600
FadeTickCooldown: 20
FadePercentageOfWreckPerCycle: 10.0
ExtraFadeTimePerBlock:
  CHEST: 600
  TRAPPED_CHEST: 600
  DISPENSER: 600
  DROPPER: 600
  FURNACE: 600
BlockQueueChunkSize: 200000
MaxRemoteSigns: -1
CraftsUseNetherPortals: true
ForbiddenRemoteSigns:
- Mounted
- Denied
- '[private]'
RequireNamePerm: false
GeneratedDatapack: true
FuelTypes:
    263: 5.0```
TylerS1066 commented 3 years ago

I am unsure why this is happening, but I will look into it sometime.

Unfortunately I do not yet have a 1.14.4 test server running, so I am unable to verify this issue or debug it. If somebody wants to boot one up and test it, that would be appreciated.

MysteryTimeTrav commented 3 years ago

I’m running it on 1.16.5 so I’m not sure if it’s an issue with my version. Does anyone know if it works in earlier versions?

TylerS1066 commented 3 years ago

Can you still replicate this problem?

I'm not noticing it on my 1.14.4 test server.

MysteryTimeTrav commented 3 years ago

it still happens in my 1.16.5 test

I’m gonna try regenerating the config file and testing different plugins to see if any other plugin is interfering with it

TylerS1066 commented 3 years ago

Aha! I figured out the problem. If you don't have FireballTracking enabled it wouldn't despawn fireballs. You can either enable it, or try this dev build: https://github.com/TylerS1066/Movecraft-Combat/suites/3378351765/artifacts/79609275

I never noticed because I've always been running my servers with fireball tracking enabled.