APDevTeam / Movecraft

The original movement plugin for Paper. Reloaded. Again.
GNU General Public License v3.0
121 stars 76 forks source link

Negative Values in dynamicFlyBlockSpeedFactor for Speed Detrimental Blocks #595

Open MysteryTimeTrav opened 1 year ago

MysteryTimeTrav commented 1 year ago

Is your feature request related to a problem? Please describe. A problem currently is that adding negative values to the dynamicFlyBlockSpeedFactor while it works, only works up to a point that adding past a certain percent of the dynamicFlyBlock to a craft will cause a ship to go extremely fast rather than slowing it down. Going into the negative values also has odd sensitivity to config changes where only extreme numbers like -60.0 will get desirable detrimental effects to speed.

Having a better system to add speed detrimental blocks would be helpful as this could introduce a new dynamic to craft types like "heavy armor" where using a too much of a certain type of armor block will slow down a ship. For example, the more endstone you use in your craft, the slower it goes. It could encourage the use of other types of armor blocks such as bringing back terracotta and slabs as these blocks could provide the same amount of belt thickness as a non speed detrimental substitute.

Describe the solution you'd like Two solutions potentially are either: -Reworking the dynamicFlyBlockSpeedFactor system to better handle negative values and non wool blocks -Adding new flags for speed detrimental blocks

TylerS1066 commented 1 year ago

I like this concept, but I think we'd probably expand the current chest penalty system to allow a custom list of blocks to be detrimental to speed.

Once we get around to re-writing speed, I think this will be high on the list to incorporate.