search

APDevTeam / Movecraft

The original movement plugin for Paper. Reloaded. Again.
GNU General Public License v3.0
122 stars 74 forks source link

Redstone block updates #622

Closed ccorp2002 closed 2 months ago

ccorp2002 commented 6 months ago

Describe in detail what your pull request accomplishes

Redstone Block Updates/Ticking on Moving Crafts should now function. (Fire on The Move, etc, redstone clocks, etc)

Checklist

drfiveminusmint commented 5 months ago

This is currently not working for me on either Paper 1.18.2 or 1.20.4. I've been using this test rig:

Screenshot 2024-02-23 112701
drfiveminusmint commented 5 months ago

Everything pilots fine, but the comparator clock freezes when cruising

ccorp2002 commented 5 months ago

It was working on my machine, ill see if i can replicate it again

drfiveminusmint commented 5 months ago

I can confirm that this works on 1.20.4, going to test it on 1.18 now

drfiveminusmint commented 5 months ago

Works on 1.18.2 too. It's a little bit hacky but it's a good starting point. 👍

ccorp2002 commented 5 months ago

Awesome! Make sure 1.19.4 also works, if you can.

TylerS1066 commented 5 months ago

Can this be expanded to fire as well? Then it would fix #500 as well.

TylerS1066 commented 5 months ago

Testing this, it seems to somewhat work on simple redstone circuits but once the complexity goes past a simple clock it fails. In addition, in the case of a simple comparator clock, the clock seems to pause for a little bit after movement, which may be contributing the to following issues. Here's a list of things I've seen fail:

  1. Simple redstone torch burnout clock gets stuck off after movement
  2. Repeater delay line gets stuck on after movement