search

APEbbers / FreeCAD-Ribbon

FreeCAD Ribbon UI
https://github.com/APEbbers/FreeCAD-Ribbon
GNU General Public License v3.0
13 stars 4 forks source link

Bug: Modifying `RibbonStructure.json` makes the FreeCAD Addon Manager to backup Ribbon WB directory #82

Closed hasecilu closed 1 hour ago

hasecilu commented 2 hours ago

Addon Manager can not do a clean pull because of the changes and clones the repo in another directory, this change makes the changes from users "lost", they need to manually copy that file again.

I think all user changes should be in a separated file, even separated in a WB-basis to prevent this issue.

Maybe even considering to put config files on $XDG_CONFIG_HOME/FreeCAD/ would be a good option.

image

APEbbers commented 1 hour ago

If added the .json files to gitignore. When "RibbonStructure.json" is not present, a copy and rename action will be done with "RibbonStructure.txt".

I believe this should solve the issue

hasecilu commented 1 hour ago

Yeah, I also think that should work. I can test when there is another change on main.

hasecilu commented 31 minutes ago

OK, it seems since the file is already commited, git tracks its changes, it should be removed from repo or use another name for the file generated by the user.

APEbbers commented 25 minutes ago

I've removed the files from the repo, so all .json files shouldn't be tracked anymore