search

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers
https://apitools.dev/json-schema-ref-parser
MIT License
957 stars 228 forks source link

Add path information to errors #163

Closed fmvilas closed 4 years ago

fmvilas commented 4 years ago

Hey! This PR adds extra information to the errors triggered when dereferencing and resolving external references. The reason I'm adding this info is that in the AsyncAPI playground, I want to find line and column of the failing $ref and with the current error I'd have to parse the error message, which is not ideal.

I suspect this info could be added to other errors too so feel free to point me out to the other places and I'll be happy to add them on this PR.

Thanks a lot for the excellent tool 🙌

fmvilas commented 4 years ago

I think this PR doesn't make sense anymore. #153 also fixed that problem.

BTW, @JamesMessinger, I've seen tests are failing for Windows. Let me know if I can help.

JamesMessinger commented 4 years ago

The failing tests on Windows are due to two new dependencies that were added in PR #153 that don't work on IE or Edge. I opened Issue #165 to discuss possible solutions.