search

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers
https://apitools.dev/json-schema-ref-parser
MIT License
957 stars 228 forks source link

Convert relative refs when resolving an external schema #220

Closed karlvr closed 1 year ago

karlvr commented 3 years ago

Possibly corrects #200.

This however causes tests to fail as they’re not expecting the references to be resolved. I’m not sure yet how to fix the tests. I thought I’d wait to see if the fix is valid!

I'd love some feedback on this to progress it or change it!

philsturgeon commented 2 years ago

@karlvr hey I've poked a few people about trying to get a review, and hopefully it'll be more successful than when I tried 14 months ago.

mikethecalamity commented 2 years ago

Bump

Borduhh commented 2 years ago

Any update on this? We'd be happy to look at the tests and change them if needed but are not maintainers on the project.

danielfcollier commented 2 years ago

Hi there,

can someone help to write tests for this feature?

I've tested with npm run coverage:node @karlvr branch, and the tests are not passing, is that right? Please, correct with I'm wrong.

There is a starting point for the tests here: https://github.com/APIDevTools/json-schema-ref-parser/commit/e1217174563c57cd81bc06259cf665606295ebf9

(I've added a branch with changes from this PR on top of some changes done for ISSUE-283 for tests on Windows.)

philsturgeon commented 1 year ago

We'd need the conflicts fixed, but seems like nobody is around to review this other than me. Gulp.

mikethecalamity commented 1 year ago

Bump? (I guess it's that time of year)

philsturgeon commented 1 year ago

@jonluca tagging you I’m if you’ve got time to have a look here. I’m not involved anymore.

jonluca commented 1 year ago

I'm open to a PR here but would need to update it to pass the tests and to use the new typescript repo. Closing this for now, feel free to open a new one

mikethecalamity commented 1 year ago

Where's the new repo?

jonluca commented 1 year ago

It's this repo - all the code was migrated to TS ~8 months ago

mikethecalamity commented 1 year ago

So I put the updates into a new PR: https://github.com/APIDevTools/json-schema-ref-parser/pull/322

But I have no idea if it's right, I've never used typescript before.