search

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers
https://apitools.dev/json-schema-ref-parser
MIT License
952 stars 227 forks source link

Package v9.0.9 is missing excludedPathMatcher functionality (that's documented on the website) #273

Closed ericallam closed 2 years ago

ericallam commented 2 years ago

As you can see in the repo, index.d.ts has the excludedPathMatcher property:

https://github.com/APIDevTools/json-schema-ref-parser/blob/main/lib/index.d.ts#L240

But if you download the NPM package (https://registry.npmjs.org/@apidevtools/json-schema-ref-parser/-/json-schema-ref-parser-9.0.9.tgz) you'll see that the property is missing. It looks like just a mistake when publishing the package most likely.

ericallam commented 2 years ago

Turns out it's not just the type, but also the functionality. deference.js in the package does not have the excludedPathMatcher functionality.

philsturgeon commented 2 years ago

@ericallam thank you for looking into this. Can you send over a PR when you get a minute?

ericallam commented 2 years ago

It's possible I was incorrect about this bug but maybe I'm just confused about how bundle should work. I'm going to investigate this further and post a new issue when I'm ready 👍