search

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers
https://apitools.dev/json-schema-ref-parser
MIT License
952 stars 227 forks source link

Issue 283 #286

Closed danielfcollier closed 1 year ago

danielfcollier commented 1 year ago

Issue: https://github.com/APIDevTools/json-schema-ref-parser/issues/283

The problem has been solved by working only with absolute paths on Windows.

Currently, there are 252 passing tests on Windows and 254 passing tests on Linux (probably MacOS too).

Some tests at:

have been fixed to work on any OS or skipped due to conflicts on Windows (error messages that still keeps the \\ from Windows.)

Three tests at test/specs/http.spec.js have been skipped and it might require opening another issue to investigate further.

danielfcollier commented 1 year ago

I will see why the CI has broken.

danielfcollier commented 1 year ago

@philsturgeon, please, run the CI again - I'm still trying to understand if the changes are enough to pass the tests pipeline.

I'm trying to run the CI locally to check first here if it is going to pass. But, it is my first try with GitHub Actions (I've just run GitLab Runner), so this is another science...

philsturgeon commented 1 year ago

Nearly there @danielfcollier, sorry this is a bit labourious. I'll add you as a collaborator so it will let the checks run qithout manual approval.

danielfcollier commented 1 year ago

Hey @philsturgeon, thanks! I will see, looking forward to solve more issues.