fix: change type of onDereference to non-required

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers

https://apitools.dev/json-schema-ref-parser

MIT License

952 stars 227 forks source link

fix: change type of onDereference to non-required #299

Closed jonluca closed 1 year ago

jonluca commented 1 year ago

The type of onDereference is required, which breaks types in some downstream packages. The code also checks for its existence on L72 of dereference.js so this is fine.

jonluca commented 1 year ago

Also @philsturgeon I'm happy to takeover this project. I was meaning to rewrite in typescript one of these days anyways

bcherny commented 1 year ago

This change looks good to me!

philsturgeon commented 1 year ago

@jonluca thank you for the fix and the offer! I’ve added you as a maintainer as well as @jamesmoschou, so the two of you could share responsibilities and review each other’s work. I’ll be around if you need anything, same username on most of the socials.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3972085564

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.8%) to 90.943%

Totals
Change from base Build 3970873546:	-4.8%
Covered Lines:	750
Relevant Lines:	787

💛 - Coveralls

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 10.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: