chore: inherit encoding type from Plugin for text parsing option

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers

https://apitools.dev/json-schema-ref-parser

MIT License

942 stars 226 forks source link

chore: inherit encoding type from Plugin for text parsing option #341

Closed liamc-altruistiq closed 4 months ago

liamc-altruistiq commented 4 months ago

When compiled, there is a type error that makes builds fail on a package that I would like to use this as a dependency. It's related to Plugin.parse.text which appears to have some overriding typing for the encoding option. This just removes that override and instead inherits the BufferEncoding type from Plugin.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8537520040

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 92.143%

Totals
Change from base Build 8180472623:	-0.07%
Covered Lines:	3363
Relevant Lines:	3622

💛 - Coveralls

liamc-altruistiq commented 4 months ago

@jonluca will a force-release be necessary here? the CI action claims that nothing of note has changed (which I guess is true) but the built dist files in the package will still contain the invalid types that are of concern.

jonluca commented 4 months ago

Yeah need to make a commit with a fix:, I'll take a look

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 11.5.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: