chore: Improve DOM-less type exports

APIDevTools / json-schema-ref-parser

Parse, Resolve, and Dereference JSON Schema $ref pointers in Node and browsers

https://apitools.dev/json-schema-ref-parser

MIT License

942 stars 226 forks source link

chore: Improve DOM-less type exports #352

Closed mdmower-csnw closed 2 months ago

mdmower-csnw commented 2 months ago

Usage of HeadersInit requires either a node-fetch dependency or to include DOM in tsconfig libs for consumer projects. It is not exported as a global type in \@types/node v18 or v20. RequestInit is:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/aaf94a0a6431f52c46dab26182f1156d79720d29/types/node/v18/globals.d.ts#L341

Define headers in interface HTTPResolverOptions<> via RequestInit['headers'] which will make it possible to depend on this project without node-fetch.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 9352827824

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 95.46%

Totals
Change from base Build 9335131703:	-0.09%
Covered Lines:	3441
Relevant Lines:	3549

💛 - Coveralls

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 11.6.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: