search

APIDevTools / swagger-parser

Swagger 2.0 and OpenAPI 3.0 parser/validator
https://apitools.dev/swagger-parser
MIT License
1.09k stars 154 forks source link

Skip known errors or unsupported api in real-world api spec #178

Closed shenie closed 3 years ago

shenie commented 3 years ago

I've skipped 3.1.0 yamls which is going to be supported only after https://github.com/APIDevTools/swagger-parser/pull/171

Then I added what I can see are errors with the api to known errors list.

fwiw the spec is also failing on v10.0.2 presumably because the swagger yaml's has changed since last tag (assuming that the build was green when last tag was made) but I'm just trying to get main green asap so that it can get another tag release... so that I can get the z-schema cve fix....

shenie commented 3 years ago

@philsturgeon pls review

philsturgeon commented 3 years ago

If somebody can get the build to pas I’ll be happy to merge it. No time to dig into why it’s failing, still on a month like bike tour of Europe. Bad WiFi I’m the desert. I believe in you!

shenie commented 3 years ago

I've fixed the lint error. How do I trigger the build again? Because I'm seeing the following message at the bottom of my PR.

''' 1 workflow awaiting approval First-time contributors need a maintainer to approve running workflows. Learn more. '''

philsturgeon commented 3 years ago

I booped it

shenie commented 3 years ago

I excluded another 3.1.0 yaml so the node 12 job should pass now. The other failure is the browser job... but I can't tell what failed....

EDIT:

The closest thing I can see in the browser job that might've been the issue are following but I'm not sure where I am supposed to do that....

11 08 2021 19:05:01.030:ERROR [launcher]: No binary for Edge browser on your platform.
362
  Please, set "EDGE_BIN" env variable.
363
11 08 2021 19:05:01.412:ERROR [launcher]: No binary for Safari browser on your platform.
364
  Please, set "SAFARI_BIN" env variable.
365
shenie commented 3 years ago

And it looks like github actions that runs the build still require approval every time I push a fix...

philsturgeon commented 3 years ago

@shenie sorry for this annoying github security feature, we've changed how tests run a little while ago and this is part of that. I'll be around my computer a bunch to click "Approve and Run" as much as needed. So far only two failing on ubuntu now!

shenie commented 3 years ago

Thanks.. working on it this morning.

shenie commented 3 years ago

Ok, pushed. npm run test:node passes on my laptop.