Closed philsturgeon closed 2 years ago
@philsturgeon
Maybe I'm wrong, but given error seems to be related to https://github.com/APIDevTools/json-schema-ref-parser/issues/199
The test is validating circular.yaml
at test/specs/circular
, wich references to definitions/person.yaml
, which references to itself as person.yaml
.
The problem is that json-schema-ref-parser
is looking for person.yaml
internal references as test/specs/circular/person.yaml
instead of test/specs/circular/definitions/person.yaml
.
I assume some upgraded dependency (maybe js-yaml?) is breaking this relative paths.
If you run release
script in main branch without upgrading dependencies, the test is passing.
I'm getting other errors with adyen
specs, but I think this errors are not related with parser but with specs.
I'm new with swagger-parser library and I'm interested on getting OpenApi 3.1 support. Let me know if I can help any way.
The testing issue here was introduced with the update to >= json-schema-ref-parser@9.0.7
. If you run this release branch against a forced version 9.0.6
you'll see the tests pass (well they fail on access of api.apis.guru
, but that site appears inaccessible ATM).
This PR https://github.com/APIDevTools/json-schema-ref-parser/pull/195 appears to introduce the breaking change, specifically around the dereferencedCache
addition.
Using the current json-schema-ref-parser@9.0.9
package and commenting out dereferencedCache.set($refPath, dereferencedObject);
allows tests to pass for example, (see: https://github.com/APIDevTools/json-schema-ref-parser/blob/748608401888e475fe052a634ee46d0ed0a54c02/lib/dereference.js#L177)
I don't know enough about the interdependencies of these packages to dig deeper for a course of resolution but am also eager to see OAS 3.1
support for this package.
@P0lip hey Jakub, I know this is outside of jurisdiction but can you help me figure out the changes to make here? @robraux has some suggestions but I don't want to break things with false positives.
Trying to get this releases as there are laods of recent improvements, including OAS 3.1 support, but I am getting a few problems.
I've had to remove
npm run update
from release because of various dependency hell problems around libsass, npm-check and uuid being triggered by audit fix. We can solve that later.With that removed I'm seeing the following test fail:
I'm a little out of the loop and honestly don't know if this is broken or working as expected and expectations changed.
@JamesMessinger sorry to bug you but could you rescue me from this rabbithole?