search

APIDevTools / swagger-parser

Swagger 2.0 and OpenAPI 3.0 parser/validator
https://apitools.dev/swagger-parser
MIT License
1.1k stars 155 forks source link

fix: ignoring a busted API that's breaking unit tests #212

Closed erunion closed 2 years ago

erunion commented 2 years ago

Ignoring this API should get all unit tests passing again so we can finally get a release out for 3.1 support.

erunion commented 2 years ago

@philsturgeon So the Node tests are working again with this but it seems that Ubuntu browser tests are failing because IE and Safari aren't available there.

18 04 2022 02:07:51.076:ERROR [launcher]: No binary for Edge browser on your platform.
  Please, set "EDGE_BIN" env variable.
18 04 2022 02:07:51.341:ERROR [launcher]: No binary for Safari browser on your platform.
  Please, set "SAFARI_BIN" env variable.

Which is weird because neither of these should be getting set up on Linux with the current karma config: https://github.com/APIDevTools/swagger-parser/blob/main/karma.conf.js#L14-L18

philsturgeon commented 2 years ago

@erunion Thanks for looking into this, and you're so close! I am about to start a 6 day ultra bikepacking race through the mountains in Italy and cannot dig into this properly but I think you can find a way to make ubuntu work, and if Node 10 is moaning just drop it, we dont need to support that old thing anyhow.