Generate a root level tags property

[crankydillo]

The code generates a tag at the operation level. I'm under the impression there's a general expectation these refer to a root-level tags property, which contains more information (as in petstore spec).

What do you think?

I'd be willing to write the code if you think it should be done.

[IvanGoncharov]

@crankydillo You right. Swagger allow operations tags not marked on top-level, but I think it's good idea to also have them on top-level.

I'd be willing to write the code if you think it should be done.

It's pretty easy to add, so I will add this today :)

P.S. You try to convert one of Google's API spec? If so please check my main project. Or it some other API documented in this format? If it public, can you please share the links?

[crankydillo]

woops, I didn't mean to do that:)

[crankydillo]

Sorry, but the specs I'm working on are private-ish.

[IvanGoncharov]

No problem. When I wrote this converter I didn't expect that somebody outside of Google use it to document APIs :)

[crankydillo]

I think my company may have come to that conclusion as well:)

[IvanGoncharov]

@crankydillo Please test it and reopen if needed.

[crankydillo]

Preliminary testing looks good. If I come across any issues with this, I'll let you know.

[crankydillo]

Wait, preliminary testing may not look good:) I believe you might be duplicating tags if there are multiple paths for the same resource. I don't mind submitting tests with issues, and as I've hinted, my team is looking to help with this tool.

How do you feel about unit testing? Do you have a preference? I'm a fan of mocha + chai (expect variant), but I'll use what you prefer. This is a sample of my typical style. I should note that I'm more of a Java/Scala guy, so I tend to use the functional programming capabilities of JS as compared to its OO (prototype) capabilities.

[IvanGoncharov]

@crankydillo Sorry, for some reason missed email notification.

I will look into duplication issue, it should be very simple fix with LoDash.

How do you feel about unit testing?

:+1: In my use case I'm focused only Google's specs, so unit-test can allow me to also consider 3rd-party spec during development.

I'm a fan of mocha + chai (expect variant), but I'll use what you prefer.

I'm new to JS(< 1year), and only thing that a worked with is mocha + chai. So it totally ok for me.

This is a sample of my typical style

Look good, except two things:

• Indentation is inconsistent. And in this lib I use two spaces.
• If you use big chunk of JSON more than 10-20 lines, please put it in separate file. Node allow you to require JSON files like that: var gdTemplate = require('./gdTemplate.json');

so I tend to use the functional programming capabilities of JS as compared to its OO

Same here, I can't leave without LoDash :)

[IvanGoncharov]

@crankydillo Sorry totally forget to remove duplicate tags. Fixed in cf293aff60f41ece67f0df62c0769c6e7d3c9297