search

APItools / middleware

APItools Middleware Repository
MIT License
61 stars 35 forks source link

Middleware testing - Ready for review #14

Closed kikito closed 10 years ago

mikz commented 10 years ago

@kikito do you mind if I reverse the params of assert.contains ?

mikz commented 10 years ago

@kidd wdyt?

kikito commented 10 years ago

do you mind if I reverse the params of assert.contains ?

Not at all, @michal. Although in that case I would rename it to assert.contained (or assert.is_contained)

@kikito why it needs to pass it when it is global value?

You are completely right. That is a mistake (I had to do that before I reimplemented spec.middleware instead of require).

kikito commented 10 years ago

:dancers: :dancer: