add function r:any() to match all methods

APItools / router.lua

A barebones router for Lua. It matches urls and executes lua functions.

MIT License

196 stars 47 forks source link

add function r:any() to match all methods #17

Closed skwerlman closed 8 years ago

skwerlman commented 8 years ago

can be used just like r:get, but matches any method. can be useful to avoid some of the replication mentioned in #9.

mikz commented 8 years ago

Thanks for the contribution! Imho a feature like this makes total sense.

I have few points to clear before we merge this.

tests. I know the test suite does not run right now, but I can't merge new functionality without tests.
passing method argument to every function. See my point https://github.com/APItools/router.lua/pull/17/files#r58670258

skwerlman commented 8 years ago

fair enough; i'll get to work on addressing these issues rn

skwerlman commented 8 years ago

hopefully, i've addressed all the problems with this pr; if so, i'll go ahead and squash this

~~actually, i've just realized ithat i should add a test for passing method~~ edit: done

mikz commented 8 years ago

@skwerlman looks good! Let me fix the build to see it green on travis.

mikz commented 8 years ago

@skwerlman master is now green (#18) so if you could rebase your PR so it is green and I'll be happy to merge! Maybe one last thing. Do you mind adding a mention to the readme?

skwerlman commented 8 years ago

i messed up my branch/fork/etc. I'm gonna reopen this against the current master to make things simpler.

New PR: #19