Closed gfabbris closed 3 years ago
Changes all PVPositionerSoftDone to a modified version from @prjemian (https://github.com/BCDA-APS/bluesky_instrument_training/blob/main/instrument/devices/temperature_signal.py), which makes the code much simpler.
PVPositionerSoftDone
There are two main differences from Pete's version:
setpoint
readback
__init__
target_attr
readback.get() - setpoint.get()
target
Close #96, closes #101.
Changes all
PVPositionerSoftDoneto a modified version from @prjemian (https://github.com/BCDA-APS/bluesky_instrument_training/blob/main/instrument/devices/temperature_signal.py), which makes the code much simpler.There are two main differences from Pete's version:
setpointandreadbackPVs in the__init__.target_attr. This is important for positioners that has ramping because if thesetpointis slowly changed by EPICS, thenreadback.get() - setpoint.get()might go to zero, and Bluesky things that the motion is done. The solution here is to create atargetsignal that will just hold to intended final position. Our lakeshore is a good example of this: https://github.com/APS-4ID-POLAR/ipython-polar/blob/6832cc2184dc3f03db01cbc0a4153aef90bf4ede/profile_bluesky/startup/instrument/devices/lakeshore340.py#L60Close #96, closes #101.