APS-4ID-POLAR / ipython-polar

4-ID-Polar ipython configuration for bluesky (and other)
1 stars 3 forks source link

Eiger support #133

Closed gfabbris closed 2 years ago

gfabbris commented 3 years ago

The setup was heavily based on the NSLS2 CHX, and the handler was based on the area_detector_handlers.eiger.EigerHandler.

Some of the most important aspects:

Closes #130.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 776c459a12e4f5357bdb8aea9a022f2464100222 into e9ac549a33e158efc2f321b2333a76a1c0de0c1c - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 12bd01b85215ddb5b5c2fc8b369e7802e5972e95 into e9ac549a33e158efc2f321b2333a76a1c0de0c1c - view on LGTM.com

new alerts:

gfabbris commented 2 years ago

The current trigger process can have a pretty bad dead time, because the PV being tracked is not optimal (the detector is ready to take another image before that). I'm exploring a change that might help in the eiger_new_mechanism banch.

gfabbris commented 2 years ago

@prjemian and @strempfer: This is ready for review.

I didn't test the latest version with the detector, but I'm willing to just merge and fix it later if needed (not sure when will have access to the detector).

Note that this creates two options of trigger, time-based and new-image-based, that can be selected during load.