search

APS-4ID-POLAR / ipython-polar

4-ID-Polar ipython configuration for bluesky (and other)
1 stars 3 forks source link

update for 2021_1 conda environment #61

Closed prjemian closed 3 years ago

prjemian commented 3 years ago

Fixes #60, includes updated ophyd support code affecting critical PV caching and timeout problems. Also includes updates to apstools, databroker,bluesky, andhklpy` and many other packages. Python 3.8.2.

prjemian commented 3 years ago

applied the program black -l 75 *.py which applies style rules such as the quotes

Web search for: python black style

On Mon, Dec 21, 2020, 7:02 PM Gilberto Fabbris notifications@github.com wrote:

@gfabbris approved this pull request.

Just a question: Why did you replace all single quotes to double?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/APS-4ID-POLAR/ipython-polar/pull/61#pullrequestreview-556754555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMBSOZJIUV4SJ5UWTZ3SV7VZPANCNFSM4VEXW5NQ .

gfabbris commented 3 years ago

@prjemian - Flake8 complains about having the logger.info(__file__) line before the other imports. But I suspect It should still stay there because it makes it easier to track an import error, is that correct?

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 2 when merging 34ad13136fd35ee497cf28f64c32a2c709347633 into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 2 alerts when merging c08ea0d32240d155345c60dec36a377aaf44ab0e into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

fixed alerts: