APS-4ID-POLAR / ipython-polar

4-ID-Polar ipython configuration for bluesky (and other)
1 stars 3 forks source link

Code cleanup #63

Closed gfabbris closed 3 years ago

gfabbris commented 3 years ago

Cleaned up a lot of the code and added the flake8 as a Github action. I've also added this repo to codacy and lgtm, but not sure it will work.

lgtm-com[bot] commented 3 years ago

This pull request fixes 7 alerts when merging a20d4313944c54fa5c1c3ee16672ecb633f17778 into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 7 alerts when merging 72e3bd4b96f303df23074a8f1034dcb1c50a17f8 into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

fixed alerts:

prjemian commented 3 years ago

IMO, let flake8 complain since we want to log the import chain when importing other modules from the instrument package.

lgtm-com[bot] commented 3 years ago

This pull request fixes 7 alerts when merging 9d6bc63f1e1d9ad0c16f0bd7967c895590451d4e into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request fixes 7 alerts when merging c948980780bb5782c38e760544ee946fb1b24a43 into 88c72170f029f2a3a3ec974e181b8b1d0009d15f - view on LGTM.com

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 5 when merging e6d32889934901321cd8cadadfc220bc13235f06 into f9affdf29ff01d4a25a5dd36d21cfead2b09b5e3 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 5 when merging 47de7561a414693b75f72211074abba6d706e587 into f9affdf29ff01d4a25a5dd36d21cfead2b09b5e3 - view on LGTM.com

new alerts:

fixed alerts: