APS-4ID-POLAR / ipython-polar

4-ID-Polar ipython configuration for bluesky (and other)
1 stars 3 forks source link

How to handle done signal in PVPositioners #96

Closed gfabbris closed 3 years ago

gfabbris commented 3 years ago

In the past we done something like:

def move(self, *args, **kwargs):
    self.done.put(0)
    return super().move(*args, **kwargs)

The above doesn't work well for some cases, like the undulatory. So it looks like the best would be:

def move(self, *args, **kwargs):
    status = super().move(*args, **kwargs)
    self.done.get()
    return status

but this needs to be tested.

gfabbris commented 3 years ago

This may be best implemented like discussed in #101.