search

APS-4ID-POLAR / polartools

Python package to read and process data from the APS Polar beamline.
https://polartools.readthedocs.io/en/latest/
Other
2 stars 2 forks source link

Code quality check? #6

Closed gfabbris closed 3 years ago

gfabbris commented 3 years ago

@prjemian: I noticed you have a couple of code quality checkers in apstools. Should I add both here as well?

prjemian commented 3 years ago

Yes. Use flake8 (in a github actions worfklow) for code style and Codacy for quality checks. The LGTM has been good to me but is getting to be slow. Still, it catches items not caught by Codacy.

On 12/18/2020 5:16 PM, Gilberto Fabbris wrote:

@prjemian https://github.com/prjemian: I noticed you have a couple of code quality checkers in |apstools|. Should I add both here as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/APS-4ID-POLAR/polartools/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMUMGZUEGISCDCS7HSNKLSVPPF3ANCNFSM4VBZQ5AA.

gfabbris commented 3 years ago

Should I separate flake8 from unit test workflow?