search

APS-4ID-POLAR / polartools

Python package to read and process data from the APS Polar beamline.
https://polartools.readthedocs.io/en/latest/
Other
2 stars 2 forks source link

Create hkl_utils.py #71

Closed strempfer closed 12 months ago

strempfer commented 1 year ago

Add hkl functions to Polartools

codecov-commenter commented 1 year ago

Codecov Report

Merging #71 (8f68560) into main (2c250f6) will decrease coverage by 9.42%. Report is 2 commits behind head on main. The diff coverage is 29.51%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   45.37%   35.95%   -9.42%     
==========================================
  Files          10       11       +1     
  Lines        1406     1777     +371     
==========================================
+ Hits          638      639       +1     
- Misses        768     1138     +370
Files Coverage Δ
polartools/__init__.py 100.00% <100.00%> (ø)
polartools/_larch.py 85.00% <100.00%> (ø)
polartools/load_data.py 73.49% <100.00%> (ø)
polartools/_pyrixs.py 92.30% <90.90%> (ø)
polartools/process_images.py 75.29% <88.88%> (ø)
polartools/area_detector_handlers.py 56.25% <25.00%> (+1.41%) :arrow_up:
polartools/pressure_calibration.py 87.75% <89.58%> (ø)
polartools/manage_database.py 53.73% <20.00%> (ø)
polartools/absorption.py 87.18% <88.79%> (ø)
polartools/diffraction.py 0.00% <0.00%> (ø)
... and 1 more
gfabbris commented 1 year ago

@strempfer - I changed most of the stuff that was just minor, but you may want to double check. The one thing we should talk about is the use of RE in br and uan, maybe we can change that to yield and add another one in polar-instrument.

gfabbris commented 12 months ago

@strempfer: I fixed some issues here that are unrelated to the hkl_utils. Is it ok if we merge it now? You can still keep working on the same branch, and we can start a new pull request when you're ready.